Subject: [Idr] Shepherd's report for draft-ietf-idr-bgp-ls-flex-algo-05.txt

From: "Dongjie (Jimmy)" <[email-masked]>
Date: Sat, 20 Feb 2021 05:40:50 +0000

Dear authors,

This is the shepherd's report for draft-ietf-idr-bgp-ls-flex-algo-05. This shepherd report is a combination from my review and a review done by Shunwan Zhuang. I appreciate his help in reviewing this IDR draft.

This document is straightforward and in a good shape. Here are some minor comments:

1.       In section 1, the flex algorithm computation is described as "the result of a flex algorithm computation is the provisioning of the Prefix SIDs associated with that algorithm with paths based on the topology computed based on that algorithm." Since a Flex-Algo is defined as the combination of calculation-type, metric-type and constraints, it may be more accurate to reflect these parameters in the above description, such as "...the Prefix SIDs associated with that algorithm with paths computed based on the calculation-type, metric-type and constraints of that algorithm".

2.       The definition of SRv6 in this draft is "SR forwarding plane on IPv6 (SRv6)", it is better to align with the definition in RFC 8754: SR over IPv6.

3.       The format of "Flex Algorithm Prefix Metric TLV" in OSPF has just been updated in draft-ietf-lsr-flex-algo-14, does the format of the corresponding TLV in BGP-LS also need to be updated? BTW, are there other changes to be made in this document to align with draft-ietf-lsr-flex-algo-14?

4.       The "Flex Algorithm Exclude SRLG TLV" in section 5 should be "Flex Algorithm Exclude SRLG sub-TLV".

Look forward to a new revision to solve the above comments. Thanks.

Best regards,
Jie