Subject: [manet] DLEP Draft 4 Nits

From: "Duke, Martin" <[email-masked]>
Date: Mon, 29 Apr 2013 21:36:17 +0000

I've articulated some difficulties I have with the data item TLVs in this and previous drafts, but here are a couple of minor questions about the Message formats in  Draft 04:

-          In 9.16: Shouldn't the draft describe the Status TLV termination codes somewhere?

-          Section 23: Why are Heartbeat Interval/Threshold TLVs in Heartbeat messages, particularly as mandatory TLVs?

-          Section 25: Shouldn't there be a Status TLV in the Link Characteristics ACK Message? I can imagine routers would want to know why their requests were refused.

Nits about draft 04:

-          MAC address is missing from the TLV table at the beginning of section 9.

-          In that same list, "Transmit Latency" should be "Latency", "Receive Resources" should be "Resources (Receive)", and "Transmit Resources" should be "Resources (Transmit)".

-          In 9.17: "indicates" -> "indicate"

-          Section 11: Heartbeat Interval/Threshold is a single TLV type, not two

-          So can LINK Characteristic ACK Timer TLVs be sent by routers? Section 9.18 suggests modems only, but Section 12 the opposite.  I vote "no."

-          Section 18: "Link Factor" -> "Link Quality"

-          Section 15 states there are no optional TLVs and then lists Status as optional.

-          Section 20 refers to "Other TLVs as listed are OPTIONAL," but there are no optional TLVs.

-          Section 22: I'm not a fan of Expected Forwarding Time but don't know why it would be excluded from Neighbor Update Messages

-          Section 24: should probably change "Current Data Rate" to "Current Data Rate (Transmit)"

-          Section 24/25: The definitions of Current Data Rate in these two sections are switched (i.e. the ACK message should take a certain form if the request is denied).

Martin