Subject: serviceChange typos

From: Abdallah Rayhan <[email-masked]>
Date: Thu, 19 Aug 1999 12:59:09 -0400

Brian,

I am saving MEGACO 15 bytes ;-)

I believe that serviceChangeXxxxxxx has a couple of typos:
1- ServiceChangeToken appears in serviceChangeRequest,
serviceChangeAccept, and serviceChangeDescriptor.
There is no need for that token to be repeated twice as it
introduces nothing. Dropping it wont change the semantics.

2-serviceChangeToken should have capital S since it is a token.

Old:
serviceChangeRequest = serviceChangeToken EQUAL TerminationID
            LBRKT serviceChangeDescriptor RBRKT

serviceChangeAccept = serviceChangeToken [EQUAL TerminationID]
           LBRKT serviceChangeDescriptor RBRKT

serviceChangeDescriptor = ServiceChangeToken LBRKT
          serviceChangeParm *(COMMA serviceChangeParm) RBRKT

Proposed:

serviceChangeRequest = ServiceChangeToken EQUAL TerminationID
            LBRKT serviceChangeParm *(COMMA serviceChangeParm) RBRKT

serviceChangeAccept = ServiceChangeToken [EQUAL TerminationID]
           LBRKT serviceChangeParm *(COMMA serviceChangeParm) RBRKT

regards
Abdallah Rayhan

---

From: Brian Rosen <[email-masked]>
Date: Thu, 19 Aug 1999 14:23:33 -0400

Fine

> -----Original Message-----
> From: Abdallah Rayhan [mailto:[email-masked]]
> Sent: Thursday, August 19, 1999 1:59 PM
> To: Brian Rosen
> Cc: [email-masked]
> Subject: Re: serviceChange typos
>
>
> If that is the rule, which I think should not be changed,
> let us call the 2nd occurrence of serviceChange as
> "Services" to help readability.
>
> Abdallah
>
> Brian Rosen wrote:
>
> > Not so fast.
> >
> > The parameter to a command is a descriptor.
> > Therefore, the parameter to serviceChange is a descriptor.
> > So, we do end up needing the serviceChange descriptor,
> > and need a token for it.
> >
> > We can, if you like, raise the issue again of whether
> > parameters to commands must be descriptors.  I think
> > it's a good rule, and given the number of times ServiceChange
> > is used, I'm not worried about efficieny in this instance.
> >
> > Brian
> >
> > > -----Original Message-----
> > > From: Abdallah Rayhan [mailto:[email-masked]]
> > > Sent: Thursday, August 19, 1999 12:59 PM
> > > To: [email-masked]
> > > Subject: serviceChange typos
> > >
> > >
> > > Brian,
> > >