Subject: Re: [nfsv4] rfc3530bis-18: Small issues in chapter 6.2.

From: "Haynes, Tom" <[email-masked]>
Date: Tue, 4 Sep 2012 15:42:24 +0000

---
Empower the team to own quality.

On Aug 10, 2012, at 6:52 AM, Marcel Telka <[email-masked]<mailto:[email-masked]>> wrote:

Hi,

Here is the chapter flow:

...
6.2.  File Attributes Discussion
6.2.1.  Attribute 12: acl
6.2.1.1.  ACE Type
6.2.1.2.  Attribute 13: aclsupport
6.2.1.3.  ACE Access Mask
6.2.1.3.1.  Discussion of Mask Attributes
6.2.1.3.2.  ACE4_DELETE vs. ACE4_DELETE_CHILD
6.2.1.4.  ACE flag
...
6.2.2.  Attribute 33: mode
...

I'd say the "6.2.1.2.  Attribute 13: aclsupport" should go "up" by one level.
It should not be a sub-chapter under "6.2.1.  Attribute 12: cal"

Actually this is by design - look at 5661 where it came from.

Now, to show that it is correct.

6.2.1 introduces the ACE structure.

   struct nfsace4 {
           acetype4                type;
           aceflag4                flag;
           acemask4                access_mask;
           utf8val_REQUIRED4       who;
   };

6.2.1.1 is the ACE type

6.2.1.2 modifies that discussion

6.2.1.3 is the ACE access mask

6.2.1.4 is the ACE flag

6.2.1.5 is the ACE who

So, if anything, I'd say that the current 6.2.1.2 should actually be 6.2.1.1.1.

.

Next issue: There are missing spaces (or a tab) here:

6.2.1.  Attribute 12: acl

  The NFSv4.0 ACL attribute contains an array of access control entries
  (ACEs) that are associated with the file system object.  Although the
  client can read and write the acl attribute, the server is
  responsible for using the ACL to perform access control.  The client
  can use the OPEN or ACCESS operations to check access without
  modifying or reading data or metadata.

  The NFS ACE structure is defined as follows:

  typedef uint32_t        acetype4;

  typedef uint32_t aceflag4;     <------------------------- HERE

fixed

  typedef uint32_t        acemask4;

Thanks.

--
Marcel Telka
RPE, Systems
_______________________________________________
nfsv4 mailing list
[email-masked]<mailto:[email-masked]>
https://www.ietf.org/mailman/listinfo/nfsv4