Subject: Re: [Teas] I-D Action: draft-ietf-teas-te-service-mapping-yang-05.txt

From: tom petch <[email-masked]>
Date: Tue, 1 Dec 2020 10:58:11 +0000

From: Teas <[email-masked]> on behalf of [email-masked] <[email-masked]>
Sent: 02 November 2020 10:07

Publish a new version and like a moth to a flame I am drawn into reviewing it.  Nothing too technical.

s.4
'figure 2 shows two distinct PNCs'
figure 3 I think

'There are four main interfaces shown in Figure 2'
I make it three or five, I struggle to see four
and it is figure 3 I think

'As shown in Figure 2'
Figure 3 I think

s.7.1
I note that the authors of the YANG modules differ from those of the I-D; some ADs dislike that but perhaps it is intentional.

Do the availability types come from any particular reference?  They make sense but I wonder if they are invented here or come from elsewhere; e.g. in other I-D similar
concepts come from the ITU-T.

'case te-topo'
I tracked Type 2 VNs down to RFC8453 and I that worth a mention e.g. 'Type 2 VNs as defined in RFC8453'
And I suspect that that RFC should be a Normative Reference

'choice te
"The TE"  '
could do with a bit more here e.g 'How the TE endpoint is defined by VN AP or by TE LTP'

s.7.2.1
The augments say 'This augment is only valid for ...' and this is often accompanied by a YANG when statement.  I suspect that a when would not make sense here since the module creates the presence container which is probably the only sensible target for a when.

This also applies to subsequent modules.

s.7.3.2
reference 
"I-D.ietf-l2nm
perhaps ietf-opsawg-l2nm
[it should have been opsawg-l2sm-l2nm but the OPSAWG WG changed the name on adoption!]

s.9
'four URIs'
I see six

'four YANG modules'
again I see six

Tom Petch

A New Internet-Draft is available from the on-line Internet-Drafts directories.
This draft is a work item of the Traffic Engineering Architecture and Signaling WG of the IETF.

        Title           : Traffic Engineering (TE) and Service Mapping Yang Model
        Authors         : Young Lee
                          Dhruv Dhody
                          Giuseppe Fioccola
                          Qin Wu
                          Daniele Ceccarelli
                          Jeff Tantsura
        Filename        : draft-ietf-teas-te-service-mapping-yang-05.txt
        Pages           : 47
        Date            : 2020-11-02

Abstract:
   This document provides a YANG data model to map customer service
   models (e.g., the L3VPN Service Model (L3SM)) to Traffic Engineering
   (TE) models (e.g., the TE Tunnel or the Virtual Network (VN) model).
   This model is referred to as TE Service Mapping Model and is
   applicable generically to the operator's need for seamless control
   and management of their VPN services with TE tunnel support.

   The model is principally used to allow monitoring and diagnostics of
   the management systems to show how the service requests are mapped
   onto underlying network resource and TE models.